Update loopdiagram.py#149
Open
RomanBurhenne wants to merge 1 commit into
Open
Conversation
When i run the loop diagrams, the inputs and outputs of the splitter and mixer branches were inversed. This way it works.
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 60.25% 60.25%
=======================================
Files 51 51
Lines 4786 4786
=======================================
Hits 2884 2884
Misses 1902 1902
Continue to review full report at Codecov.
|
Owner
|
@RomanBurhenne , Thanks for fixing that. I'll review the code and merge in a few days. |
Owner
|
@RomanBurhenne , your update looks straightforward. The original loopdiagram.py seems broken for some reason. I need to look into that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i run the loop diagrams, the inputs and outputs of the splitter and mixer branches were inversed. This way it works.