User exposure tagging #385
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tagging to the top-levels of the rest of algorithms module.
Temporarily disable the on-push unit testing in anticipation for many comment-only commits getting pushed to this branch.
Added agreements with others' markings for the rest of algorithms/ subpackage and added new markings for modules in baseobjs/
|
An update on this: We've decided to also try to do this piecewise as we touch various parts of the code for other fixes. This means that user-exposure tags will not be limited to this branch/PR. We may have merge conflicts as different people tag different parts with exposure, but this will either serve to a) validate the exposure level if they match or b) cause discussion if they don't match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work-in-progress PR means to address #354.
The plan is to keep this PR open and for each of us to periodically update this branch. @enielse has gotten us started with tagging a few modules. Although the process has just begun, we've already found a module that has minimal user exposure and that's "forsaken"! (Ripe for the removing!)
Tips for working on this:
Pull from GitHub before making changes. There's a chance someone else might have already pushed some work you don't see on your local repo.
If you're about to spend a while on this (say, more than 15 minutes) then it would probably be a good idea to post here and explain what (sub) folders you're looking at. That way we don't duplicate effort.
CC: @sserita and @coreyostrove.