Skip to content

RKPM kernel weights #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kuberry wants to merge 3 commits into
base: master
Choose a base branch
from
Open

RKPM kernel weights #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae9441b
Preliminary _epsilons_from_targets
kuberry Mar 10, 2026
c78f4c0
Switch from bool _epsilons_from_targets to _epsilons_from_sources view
kuberry Mar 10, 2026
2ab6dfc
Fix use of _epsilons_from_sources
kuberry Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Compadre_Basis.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,8 @@ void createWeightsAndP(const BasisData& data, const member_type& teamMember, scr
}

// generate weight vector from distances and window sizes
w(i+my_num_neighbors*d) = GMLS::Wab(r, data._epsilons(target_index), data._weighting_type, data._weighting_p, data._weighting_n);
const double cutoff_p = (data._epsilons_from_sources.extent(0) == 0) ? data._epsilons(target_index) : data._epsilons(data._pc.getNeighborIndex(target_index, i));
w(i+my_num_neighbors*d) = GMLS::Wab(r, cutoff_p, data._weighting_type, data._weighting_p, data._weighting_n);

calcPij<BasisData>(data, teamMember, delta.data(), thread_workspace.data(), target_index, i + d*my_num_neighbors, 0 /*alpha*/, dimension, polynomial_order, false /*bool on only specific order*/, V, reconstruction_space, polynomial_sampling_functional);

Expand Down Expand Up @@ -964,6 +965,7 @@ void createWeightsAndPForCurvature(const BasisData& data, const member_type& tea

// ignores V when calculating weights from a point, i.e. uses actual point values
double r;
const double cutoff_p = (data._epsilons_from_sources.extent(0) == 0) ? data._epsilons(target_index) : data._epsilons(data._pc.getNeighborIndex(target_index, i));

// get Euclidean distance of scaled relative coordinate from the origin
if (V==NULL) {
Expand All @@ -974,10 +976,10 @@ void createWeightsAndPForCurvature(const BasisData& data, const member_type& tea

// generate weight vector from distances and window sizes
if (only_specific_order) {
w(i) = GMLS::Wab(r, data._epsilons(target_index), data._curvature_weighting_type, data._curvature_weighting_p, data._curvature_weighting_n);
w(i) = GMLS::Wab(r, cutoff_p, data._curvature_weighting_type, data._curvature_weighting_p, data._curvature_weighting_n);
calcPij<BasisData>(data, teamMember, delta.data(), thread_workspace.data(), target_index, i, 0 /*alpha*/, dimension, 1, true /*bool on only specific order*/);
} else {
w(i) = GMLS::Wab(r, data._epsilons(target_index), data._curvature_weighting_type, data._curvature_weighting_p, data._curvature_weighting_n);
w(i) = GMLS::Wab(r, cutoff_p, data._curvature_weighting_type, data._curvature_weighting_p, data._curvature_weighting_n);
calcPij<BasisData>(data, teamMember, delta.data(), thread_workspace.data(), target_index, i, 0 /*alpha*/, dimension, data._curvature_poly_order, false /*bool on only specific order*/, V);
}

Expand Down
1 change: 1 addition & 0 deletions src/Compadre_Functors.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ struct GMLSBasisData {
Kokkos::View<double**, layout_right> _source_extra_data;
Kokkos::View<double**, layout_right> _target_extra_data;
Kokkos::View<double*> _epsilons;
Kokkos::View<double*> _epsilons_from_sources;
Kokkos::View<double*****, layout_right> _prestencil_weights;
Kokkos::View<TargetOperation*> _curvature_support_operations;
Kokkos::View<TargetOperation*> _operations;
Expand Down
12 changes: 9 additions & 3 deletions src/Compadre_GMLS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ void GMLS::generatePolynomialCoefficients(const int number_of_batches, const boo
_h_ss._neighbor_lists = _pc._nla;
_h_ss._max_evaluation_sites_per_target = _additional_pc._nla.getMaxNumNeighbors() + 1;

// check that window sizes match number of either target or source sites
compadre_assert_release(this->_epsilons.extent(0)==this->_pc._target_coordinates.extent(0));
compadre_assert_release(this->_epsilons_from_sources.extent(0)<=0
|| this->_epsilons_from_sources.extent(0)==this->_pc._source_coordinates.extent(0));

/*
* Generate Quadrature
*/
Expand Down Expand Up @@ -526,10 +531,11 @@ const GMLSBasisData GMLS::extractBasisData() const {
data._source_extra_data = gmls._source_extra_data;
data._target_extra_data = gmls._target_extra_data;
data._pc = gmls._pc;
data._epsilons = gmls._epsilons ;
data._prestencil_weights = gmls._prestencil_weights ;
data._epsilons = gmls._epsilons;
data._epsilons_from_sources = gmls._epsilons_from_sources;
data._prestencil_weights = gmls._prestencil_weights;
data._additional_pc = gmls._additional_pc;
data._poly_order = gmls._poly_order ;
data._poly_order = gmls._poly_order;
data._curvature_poly_order = gmls._curvature_poly_order;
data._NP = gmls._NP;
data._global_dimensions = gmls._global_dimensions;
Expand Down
34 changes: 32 additions & 2 deletions src/Compadre_GMLS.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ friend class Evaluator;

//! h supports determined through neighbor search (device)
Kokkos::View<double*> _epsilons;

//! optional, h supports determined through neighbor search (device)
//! which is only used in the kernel
Kokkos::View<double*> _epsilons_from_sources;

//! generated weights for nontraditional samples required to transform data into expected sampling
//! functional form (device).
Expand Down Expand Up @@ -735,6 +739,12 @@ friend class Evaluator;
//! Get a view (device) of all window sizes
decltype(_epsilons)* getWindowSizes() { return &_epsilons; }

//! Get a view (device) of all window sizes
decltype(_epsilons)* getWindowSizesFromSourceSites() {
compadre_assert_release(this->_epsilons_from_sources.extent(0)>0);
return &_epsilons_from_sources;
}

//! Get a view (device) of all tangent direction bundles.
decltype(_T)* getTangentDirections() { return &_T; }

Expand Down Expand Up @@ -1044,10 +1054,8 @@ friend class Evaluator;
//! Sets window sizes, also called the support of the kernel
template<typename view_type>
void setWindowSizes(view_type epsilons) {

// allocate memory on device
_epsilons = decltype(_epsilons)("device epsilons", epsilons.extent(0));

// copy data from host to device
Kokkos::deep_copy(_epsilons, epsilons);
this->resetCoefficientData();
Expand All @@ -1061,6 +1069,28 @@ friend class Evaluator;
this->resetCoefficientData();
}

//! (OPTIONAL)
//! Sets window sizes, also called the support of the kernel
template<typename view_type>
void setWindowSizesFromSourceSites(view_type epsilons) {
compadre_assert_release(epsilons.extent(0)==this->_pc._source_coordinates.extent(0));
// allocate memory on device
_epsilons_from_sources = decltype(_epsilons_from_sources)("device epsilons from source sites", epsilons.extent(0));
// copy data from host to device
Kokkos::deep_copy(_epsilons, epsilons);
this->resetCoefficientData();
}

//! (OPTIONAL)
//! Sets window sizes, also called the support of the kernel (device)
template<typename view_type>
void setWindowSizesFromSourceSites(decltype(_epsilons_from_sources) epsilons) {
compadre_assert_release(epsilons.extent(0)==this->_pc._source_coordinates.extent(0));
// allocate memory on device
_epsilons_from_sources = epsilons;
this->resetCoefficientData();
}

//! (OPTIONAL)
//! Sets orthonormal tangent directions for reconstruction on a manifold. The first rank of this 2D array
//! corresponds to the target indices, i.e., rows of the neighbor lists 2D array. The second rank is the
Expand Down
Loading