Skip to content

feat: overall=True adds the all-domains row beside by= - #315

Closed
MamadouSDiallo wants to merge 1 commit into
mainfrom
feat/overall-row
Closed

MamadouSDiallo wants to merge 1 commit into
mainfrom
feat/overall-row

Conversation

@MamadouSDiallo

Copy link
Copy Markdown
Contributor

mean, total, prop, ratio, quantile, median take overall=True (with by=): the result is the by= rows plus the by=None rows, exactly the two calls' numbers, listed last, null in the domain columns, printed as "All". Lists (several y or p) get it per member. Serialized payloads mark the rows with by=None.

Covariance: the overall rows come from their own call, so the combined result is marked unfilled and contrast() refuses with a pointer to the by= result (same rule as multi-variable lists). Joint domain/overall covariance would need kernel support.

overall=True without by= raises OVERALL_WITHOUT_BY.

@MamadouSDiallo

Copy link
Copy Markdown
Contributor Author

Closing: two calls glued together, with no joint covariance. If an overall row comes back it should be one kernel pass with the overall as an extra domain, so domain-vs-overall contrasts work.

@MamadouSDiallo
MamadouSDiallo deleted the feat/overall-row branch October 17, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant