Repository navigation
feat: overall=True adds the all-domains row beside by= - #315
Closed
MamadouSDiallo wants to merge 1 commit into
Closed
MamadouSDiallo wants to merge 1 commit into
MamadouSDiallo wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing: two calls glued together, with no joint covariance. If an overall row comes back it should be one kernel pass with the overall as an extra domain, so domain-vs-overall contrasts work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mean,total,prop,ratio,quantile,mediantakeoverall=True(withby=): the result is theby=rows plus theby=Nonerows, exactly the two calls' numbers, listed last, null in the domain columns, printed as "All". Lists (severalyorp) get it per member. Serialized payloads mark the rows withby=None.Covariance: the overall rows come from their own call, so the combined result is marked unfilled and
contrast()refuses with a pointer to theby=result (same rule as multi-variable lists). Joint domain/overall covariance would need kernel support.overall=Truewithoutby=raisesOVERALL_WITHOUT_BY.