Repository navigation
feat: serialize table units, ttest by domain, GLM term structure; from_dict - #313
Merged
Merged
Conversation
…m_dict svy-result/0.9. Optional fields, so older payloads decode. Also carries a two-group t-test's group labels, which serialization dropped.
…er-asks # Conflicts: # packages/svy/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema
svy-result/0.9; every new field is optional, so older payloads decode withNone.TableData.units(andTable.units):"proportion","percent"or"count".ttest(..., by=...)serializes asttest_one_group_by/ttest_two_groups_by(oneresultslist of a single member type;kindstays a plain field, so no struct union).to_polars(data)matches the live result,row_indexcounts through members.GLMFitData.terms(type, levels, reference, value labels);GLMCoefData.labelandparts, one(variable, level)per factor, interactions included, taken from the fit's dummy map, not the column name.svy.serialize.from_dict; decode errors namefrom_dictorfrom_json.GroupLevelsData.labels, so a serialized two-group t-test keeps its<group>_labelcolumn.DESIGN.md:kindis not msgspec'stag_field; 0.9 fields documented.Golden fixtures regenerated (version bump and the new fields only).
test_every_serializable_kind_has_a_tablenow allows one serializer with two kinds.