iam: getInlinePolicyDetails API(GCP) #163
Open
+87
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (70.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
============================================
- Coverage 83.59% 83.57% -0.02%
- Complexity 90 93 +3
============================================
Files 150 150
Lines 8046 8051 +5
Branches 942 944 +2
============================================
+ Hits 6726 6729 +3
- Misses 875 876 +1
- Partials 445 446 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LihaoLiuXs
reviewed
Dec 3, 2025
| * | ||
| * @param identityName the name of the identity | ||
| * @param policyName the name of the policy | ||
| * @param policyName the name of the policy. This parameter is optional and subject to cloud semantics. |
Collaborator
There was a problem hiding this comment.
Do we need to update our AwsIam for this function signature change?
LihaoLiuXs
reviewed
Dec 3, 2025
| * @return the policy document details as a string | ||
| */ | ||
| public String getInlinePolicyDetails(String identityName, String policyName, String tenantId, String region) { | ||
| public String getInlinePolicyDetails(String identityName, String policyName, String roleName, String tenantId, String region) { |
Collaborator
There was a problem hiding this comment.
What's the reason for adding this roleName? Is it for aws and ali?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
< Provide a brief description of the changes in this PR >
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: