MOB-4993: Make visitor code dialog non-dismissible#1471
Open
gugalo wants to merge 5 commits intodevelopmentfrom
Open
MOB-4993: Make visitor code dialog non-dismissible#1471gugalo wants to merge 5 commits intodevelopmentfrom
gugalo wants to merge 5 commits intodevelopmentfrom
Conversation
Configuration simplification: - Remove Atlassian MCP (delegated to global config) - Replace GitHub MCP with direct gh CLI usage - Remove iOS Simulator MCP (not needed for Android SDK) - Add gh search permission for code searching - Add all mobile-mcp tool permissions for Android emulator control Documentation improvements: - Remove hardcoded dependency versions from CLAUDE.md - Add references to gradle/libs.versions.toml as single source of truth - Update GitHub integration docs to reflect direct CLI usage - Clarify Atlassian MCP uses global configuration Files changed: 3 files, 26 insertions(+), 105 deletions(-) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Removed unused MCP servers from configuration. chore/claude-code-setup
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
This PR makes the visitor code dialog non-dismissible by disabling cancelable behavior, aligning Android with iOS implementation to prevent accidental dismissals during call visualizer engagement.
Changes:
- Changed
setCancelable(true)tosetCancelable(false)in the visitor code dialog configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .setBackgroundInsetEnd(0) | ||
| .setCancelable(true) | ||
| .setCancelable(false) | ||
| .setOnCancelListener { Dependencies.controllerFactory.callVisualizerController.dismissVisitorCodeDialog() } |
There was a problem hiding this comment.
The setOnCancelListener on line 386 will never be invoked since setCancelable(false) prevents the dialog from being canceled. Consider removing this listener or documenting why it's retained.
Suggested change
| .setOnCancelListener { Dependencies.controllerFactory.callVisualizerController.dismissVisitorCodeDialog() } |
Collaborator
There was a problem hiding this comment.
@gugalo this proposed change seems reasonable. Can you please make the change on Monday?
Update the visitor code dialog to prevent dismissal by tapping outside or pressing the back button. The dialog can now only be dismissed via the X button in the UI, matching the iOS implementation. Changes: - Set setCancelable(false) in showVisitorCodeDialog() - Aligns Android behavior with iOS for consistent UX - Prevents accidental dismissal during call visualizer engagement Ticket: MOB-4993
gugalo
force-pushed
the
feature/MOB-4993-visitor-code-non-dismissible
branch
from
6b5776e to
e5d81fb
Compare
Andrii-Horishnii-Glia
force-pushed
the
development
branch
from
ac26cd6 to
d092a22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the visitor code dialog non-dismissible by tapping outside or pressing the back button, matching the iOS implementation. The dialog can now only be dismissed via the X button in the UI.
Changes
setCancelable(true)tosetCancelable(false)inshowVisitorCodeDialog()functionwidgetssdk/src/main/java/com/glia/widgets/view/Dialogs.kt(line 385)Why This Change?
Technical Details
MaterialAlertDialogBuilder.setCancelable(false)Related