Fix Storybook follow-up cleanup and boolean attribute alignment#83
Open
vagxrth wants to merge 1 commit into
Open
Fix Storybook follow-up cleanup and boolean attribute alignment#83vagxrth wants to merge 1 commit into
vagxrth wants to merge 1 commit into
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 15 minutes and 31 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (72)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the focused Storybook follow-up cleanup for issue #57 without widening into unrelated refactors.
It cleans up Storybook testing taxonomy, removes repeated testing config, aligns boolean-attribute handling between Storybook and runtime behavior, and deduplicates shared no-data fixtures.
Closes #57.
What Changed
Shared Storybook cleanup
StoryObj<any>usages withStoryObj<typeof meta>Boolean attribute alignment
"false"for presence-style booleans"false"semantics for:show-participantsshow-participant-countTargeted runtime consistency fixes
nostr-profilenow uses shared boolean parsing for:show-npubshow-follownostr-postnow uses shared boolean parsing for:show-statsnostr-follow-buttonnow uses shared boolean parsing for:show-avatarStorybook taxonomy and story cleanup
Component/Testing/ValidComponent/Testing/InvalidComponent/Testing/No DataComponent/Testing/DynamicComponent/Testing/Dashboarddata-themeinstead ofthemeShared no-data fixtures
Verification
Ran:
npm test -- --runnpm run build-storybookResults: