Skip to content

Update UsernameGeneratorTest.java#8

Open
sunnyajmera wants to merge 11 commits intosailpoint-oss:mainfrom
sunnyajmera:patch-1
Open

Update UsernameGeneratorTest.java#8
sunnyajmera wants to merge 11 commits intosailpoint-oss:mainfrom
sunnyajmera:patch-1

Conversation

@sunnyajmera
Copy link

Removed the internationalized version of e character as it was throwing error while building the code.

Error
INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] UsernameGeneratorTest.testUsernameGeneratorWhereFirstAndLastNameValid:50 expected: <tylar.smith> but was: <tyler.smith>
[INFO]
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0
[INFO]

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@colin-mckibben-sp colin-mckibben-sp force-pushed the main branch 2 times, most recently from b81826a to 8f7e481 Compare October 11, 2023 20:30
Copy link
Contributor

@tyler-mairose-sp tyler-mairose-sp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sunnyajmera,

If you pull the latest changes from the repository this should not be an issue. I added logic to remove diacritical marks so the test should pass.

Please let me know and I can close this PR!

@sunnyajmera
Copy link
Author

Hello @sunnyajmera,

If you pull the latest changes from the repository this should not be an issue. I added logic to remove diacritical marks so the test should pass.

Please let me know and I can close this PR!

I still don't see the change and issue is still happening even after pulling the latest.

@bhsf-james-pannell
Copy link

Late to the party, but this is an issue caused the system default encoding when using Maven on Windows. There are hints of an issue because Maven outputs messages like file encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!. To resolve this on Windows, I would just set it explicitly in the pom.xml in the properties section:

    <properties>
        <maven.compiler.source>17</maven.compiler.source>
        <maven.compiler.target>17</maven.compiler.target>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <!-- This !-->
        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> <!-- This !-->
    </properties>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants