fixed lint.sh, allowed 'all' to be passed to lint.sh to lint everything, not just changed files, and updated readme accordingly#9
Open
billy-kimble-sp wants to merge 2 commits intomainfrom
Open
Conversation
…ng, not just changed files, and updated readme accordingly
| then | ||
| files=$(find . -name "*.yaml") | ||
| else | ||
| files=$(git diff --name-only HEAD main) |
Contributor
There was a problem hiding this comment.
Are you linting agains cloud-api-client-commons? I don't see a main branch on our internal spec repo, just master.
Comment on lines
-39
to
-54
| path-parameters-must-have-valid-formats-for-numbers-and-integers: | ||
| message: "{{error}}: https://sailpoint-oss.github.io/sailpoint-api-guidelines/#171" | ||
| given: $.[*].parameters[?(@.$ref == null)] | ||
| severity: error | ||
| then: | ||
| function: path-parameter-integer-number-formats | ||
| functionOptions: | ||
| rule: 171 | ||
| path-summary-length: | ||
| message: "{{error}}: https://sailpoint-oss.github.io/sailpoint-api-guidelines/#305" | ||
| given: $[*].summary | ||
| severity: warn | ||
| then: | ||
| function: word-count | ||
| functionOptions: | ||
| maxWordCount: 5 |
Contributor
There was a problem hiding this comment.
Why are all of these path and schema rules commented out?
Contributor
|
@billy-kimble-sp Thank you for your contribution, and sorry it took so long to get back to you. I want to get your changes merged, but I'll need you to resolve the conflicts and comments first. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lint.sh was hardcoded to look at master but api-specs uses main , so it was failing to run lint on the changed files. I fixed that. While in there, I also realized there was no ability to run lint on everything regardless of it was changed, so I added that ability via an argument too.