This repository was archived by the owner on Feb 20, 2023. It is now read-only.
Allow enable.sh to work with zsh #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haraldschilly can you look at this -- I think you wrote enable.sh, since I don't remember it? |
|
I did a rebase followed by a commit that removes the line from the |
|
Sorry for overlooking this, but merge conflict! |
dimpase
reviewed
Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address #28 . I'm inexperienced with shell scripts so be very skeptical of my PR! But I tried my best.
I changed the single brackets to double brackets so it works with
zsh.If the script detects that this is being sourced from
zsh, we use${(%):-%x}instead of$BASH_SOURCE(stolen from here: https://stackoverflow.com/a/28336473)I did some refactoring to remove some
exit 1. This is because, when being sourced, this script would use to print the error message and then exit immediately so the user would have no idea what went wrong!