Skip to content

Memoizing FrameContextProvider value #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Memoizing FrameContextProvider value #223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef8e16
adding usememo for context value
nickskotny Sep 13, 2022
7d8eeb7
updating Frame
nickskotny Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Frame.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export class Frame extends Component {
this._isMounted = false;
this.nodeRef = React.createRef();
this.state = { iframeLoaded: false };
this.contextValue = null;
}

componentDidMount() {
Expand Down Expand Up @@ -99,12 +100,21 @@ export class Frame extends Component {
const contentDidUpdate = this.props.contentDidUpdate;

const win = doc.defaultView || doc.parentView;

const contextValue = { document: doc, window: win };

const prevContextValue = this.contextValue

if (!prevContextValue || prevContextValue.document !== contextValue.document || prevContextValue.window !== contextValue.window){
this.contextValue = contextValue
}

const contents = (
<Content
contentDidMount={contentDidMount}
contentDidUpdate={contentDidUpdate}
>
<FrameContextProvider value={{ document: doc, window: win }}>
<FrameContextProvider value={this.contextValue}>
<div className="frame-content">{this.props.children}</div>
</FrameContextProvider>
</Content>
Expand Down