Skip to content

Add JaxDataset benchmark variants#81

Draft
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
benchmark-jax-dataset-13512845416299830764
Draft

Add JaxDataset benchmark variants#81
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
benchmark-jax-dataset-13512845416299830764

Conversation

@google-labs-jules
Copy link
Contributor

Added a comparison of three marginal computation methods to benchmarks/benchmark_marginals.py:

  1. JIT on CliqueVector.from_projectable (compiles the entire loop).
  2. JIT on JaxDataset.project (cached, compiles per clique).
  3. No JIT (eager execution).

Also updated src/mbi/dataset.py to support JIT compilation by passing the static length parameter to jnp.bincount in JaxDataset.project.

Results indicate that JIT on CliqueVector is fastest for small to medium N (0.16s for N=10k vs 80s for No JIT), but fails with OOM for N=1M on standard hardware. JIT on project is extremely slow due to excessive recompilation overhead. No JIT provides stable scaling.


PR created automatically by Jules for task 13512845416299830764 started by @ryan112358

@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants