Skip to content

Remove technical reason for desync from desync window#836

Open
mibac138 wants to merge 1 commit intorwmt:devfrom
mibac138:hide-technical-desync-details
Open

Remove technical reason for desync from desync window#836
mibac138 wants to merge 1 commit intorwmt:devfrom
mibac138:hide-technical-desync-details

Conversation

@mibac138
Copy link
Contributor

@mibac138 mibac138 commented Mar 17, 2026

This can be confusing and doesn't provide much value on it's own (e.g. when someone joins the Discord and just says they have Wrong random state on map). It can also lead users to mistakenly thinking a different issue is the same as their own because the headline is the same.

The text is still present in the log file.

@Zetrith @notfood @SokyranTheDragon thoughts?

This can be confusing and doesn't provide much value on it's own (e.g.
when someone joins the Discord and just says they have Wrong random
state on map). It can also lead users to mistakenly thinking a different
issue is the same as their own because the headline is the same.

The text is still present in the log file
@notfood notfood added the enhancement New feature or request. label Mar 17, 2026
@notfood notfood moved this to In review in 1.6 and Odyssey Mar 17, 2026
@notfood
Copy link
Member

notfood commented Mar 17, 2026

For user reports it's not very useful. Maybe just keep it enabled for dev if we need it. I don't mind either way.

@rautamiekka
Copy link

rautamiekka commented Mar 17, 2026

No.

Removing it will do more harm than good, it's at least a starting point, even if you won't report it or try to debug it in any way; removing will make the mod look like it has no, or less, clue what happened, especially when you ain't new like me & my friend are.

At the very least the reason suddenly changing between desyncs will indicate something has gone worse.

I don't have a better way, though.

@mibac138
Copy link
Contributor Author

This PR is not a hill I'm going to die on, but I'd like to understand why do you think it's a bad change.

Removing it will do more harm than good, it's at least a starting point, even if you won't report it or try to debug it in any way

If you aren't going to do anything about the desyncs, then what does it even matter? It's a starting point for what?

removing will make the mod look like it has no, or less, clue what happened

The mod doesn't really know why a desync has happened, it only knows that it did happen and what were the last actions (simplified) before the desync (available in the desync file which also has a lot more info).

especially when you ain't new like me & my friend are.

At the very least the reason suddenly changing between desyncs will indicate something has gone worse.

If you are curious you can just enable dev mode in the game options and you'll still see the reason, and if you're willing to debug the issue, the text is probably not going to be super useful and you'll almost certainly use the desync file (which still contains the reason) anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request.

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants