Skip to content

Conversation

@djc
Copy link
Member

@djc djc commented Oct 13, 2025

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wording nit, but in sum LGTM. Thanks!

@djc djc force-pushed the tweak-csr-errors branch from d992370 to 39e8a81 Compare October 14, 2025 14:18
@dwhjames
Copy link
Contributor

Following up from:

Note, there are now three distinct ways that the context of a CSR is indicated in an error name:

/// The given certificate signing request couldn't be parsed
CouldNotParseCertificationRequest,

rcgen/rcgen/src/error.rs

Lines 13 to 15 in 39e8a81

/// The CSR signature is invalid
#[cfg(feature = "x509-parser")]
InvalidRequestSignature,

rcgen/rcgen/src/error.rs

Lines 42 to 43 in 39e8a81

/// Unsupported field when generating a CSR
UnsupportedInCsr,

Probably other things to critique about Error::InvalidSignatureInCsr, but it does avoid creating a 3rd naming style.

@djc
Copy link
Member Author

djc commented Oct 15, 2025

That's fair. I've renamed InvalidRequestSignature to InvalidCertificationRequestSignature to alleviate that concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants