- 
                Notifications
    You must be signed in to change notification settings 
- Fork 237
Add release.yml CI action #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Added code from https://medium.com/@usman_qb/from-git-tag-to-github-release-automating-changelog-extraction-9cfcad1b13c4 (modified slightly due to our tag format). I don't know how to test this other than to make a release. | 
897c11e    to
    990f1a5      
    Compare
  
            
          
                .github/workflows/release.yml
              
                Outdated
          
        
      | - name: Create release body | ||
| id: create_release_body | ||
| run: | | ||
| RELEASEVERSION="[${{ '[' + github.ref_name.slice(1) + ']' }}]" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assumption: we can evaluate JavaScript here. GH docs seem to imply this.
| I believe this should work as intended, or at least not cause problems: 
 Testing needed, somewhere. | 
| LGTM on the first glance, but note that I do not have experience of using Trusted Publishing. | 
| Me neither, and while not giving GH Actions long-lived tokens is a good thing, this still fundamentally gives Actions the ability to publish crates. Whether or not we want that is another question. (My main motivation here was exploring possibilities. It may be that we want the GH release stuff but not the crates.io publishing.) What I do like is that this approach associates crates.io releases with git tags (assuming one does not publish to crates.io first). | 
This is the repo-side configuration of https://crates.io/docs/trusted-publishing