Replace unmaintained android-properties crate with ndk API
#213
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was surprised to find [the `android-properties` crate] with almost 8 *million* downloads; this crate hasn't been updated for almost 5 years and the repository is a public archive. Turns out the only published user of this crate is `android-activity`, so all those downloads are pulled in from folks using this crate (mainly through `winit`) to build Android apps. Instead of using an unmaintained, archived crate, use the properties wrapper and typed API-level wrappers provided in in an upcoming `ndk` crate release instead: - rust-mobile/ndk#495 - rust-mobile/ndk#479 [the `android-properties` crate]: https://crates.io/crates/android-properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to find the
android-propertiescrate with almost 8 million downloads; this crate hasn't been updated for almost 5 years and the repository is a public archive.Turns out the only published user of this crate is
android-activity, so all those downloads are pulled in from folks using this crate (mainly throughwinit) to build Android apps.Instead of using an unmaintained, archived crate, use the properties wrapper and typed API-level wrappers provided in in an upcoming
ndkcrate release instead: