Forward TEST_SAMPLE_INTRINSICS_PERCENTAGE
#1948
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
commented
Oct 26, 2025
Comment on lines
47
to
55
| let intrinsics = | ||
| let mut intrinsics = | ||
| get_xml_intrinsics(&cli_options.filename).expect("Error parsing input file"); | ||
|
|
||
| intrinsics.sort_by(|a, b| a.name.cmp(&b.name)); | ||
| intrinsics.dedup(); | ||
|
|
||
| let sample_percentage: usize = cli_options.sample_percentage as usize; | ||
| let sample_size = (intrinsics.len() * sample_percentage) / 100; | ||
|
|
||
| let mut intrinsics = intrinsics | ||
| let intrinsics = intrinsics |
There was a problem hiding this comment.
@madhav-madhusoodanan does this look right to you? CI failed on this before complaining it cannot find mod_0.o which I think can only happen if we somehow filter out all intrinsics.
There was a problem hiding this comment.
Ah, got it. We have duplicate definitions of a couple of intrinsics. e.g.
<intrinsic name="_mm256_dpbusds_epi32" tech="AVX_ALL">
<intrinsic name="_mm256_dpbusds_epi32" tech="AVX-512">
So we really need to dedup by the name.
folkertdev
force-pushed
the
forward-percentage
branch
4 times, most recently
from
cbb239c to
678d57e
Compare
folkertdev
force-pushed
the
forward-percentage
branch
from
678d57e to
1062fc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when iterating on
intrinsic-testso you don't need to wait for all intrinsics to get tested.I'm also enabling more logs, that seems useful to just kind of see what it's doing, and less of a problem now that the intrinsic tests are in their own CI actions.