Skip to content

Conversation

@wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Dec 4, 2025

Totally clean revert, tests pass on my local machine.

Fixes #149081 on 1.92 beta

cc @lcnr @BoxyUwU @jieyouxu @cjgillot

@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to constck

cc @fee1-dead

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2025

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 4, 2025
@Amanieu Amanieu removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Dec 4, 2025
@wesleywiser
Copy link
Member Author

A revert was the preferred option discussed during today's compiler triage meeting.

Since the revert was clean and all tests are passing:

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Dec 4, 2025

📌 Commit 9deb2c4 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Dec 5, 2025

(Since this is targetting beta and stable is close)
@bors p=10 (ahead of rollups)

@jieyouxu
Copy link
Member

jieyouxu commented Dec 5, 2025

@bors rollup=never (beta revert)

@bors
Copy link
Collaborator

bors commented Dec 5, 2025

⌛ Testing commit 9deb2c4 with merge 5cd7b31...

@bors
Copy link
Collaborator

bors commented Dec 5, 2025

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 5cd7b31 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 5, 2025
@bors bors merged commit 5cd7b31 into rust-lang:beta Dec 5, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Dec 5, 2025
@apiraino
Copy link
Contributor

apiraino commented Dec 5, 2025

Beta backport approved based on a check on Zulip. This is directly applied on the beta branch, so no additional PR is needed.

(Replaces #149501)

Thank you @wesleywiser !

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 5, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants