-
Notifications
You must be signed in to change notification settings - Fork 14.1k
[beta] Revert "Replace NullOp::SizeOf and NullOp::AlignOf by lang items." #149649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 5dfbf67.
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in src/tools/clippy cc @rust-lang/clippy This PR changes a file inside This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @vakaras Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 The Miri subtree was changed cc @rust-lang/miri Some changes occurred to constck cc @fee1-dead Some changes occurred to the CTFE machinery |
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
|
A revert was the preferred option discussed during today's compiler triage meeting. Since the revert was clean and all tests are passing: @bors r+ p=1 |
|
(Since this is targetting beta and stable is close) |
|
@bors rollup=never (beta revert) |
|
☀️ Test successful - checks-actions |
|
Beta backport approved based on a check on Zulip. This is directly applied on the beta branch, so no additional PR is needed. (Replaces #149501) Thank you @wesleywiser ! @rustbot label +beta-accepted |
Totally clean revert, tests pass on my local machine.
Fixes #149081 on 1.92 beta
cc @lcnr @BoxyUwU @jieyouxu @cjgillot