Stop adding MSYS2 to PATH #149516
Merged
Stop adding MSYS2 to PATH #149516
+0
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust no longer requires MSYS2 tools like make.
rustbot
added
A-CI
Member
Author
|
@bors try jobs=dist-i686-mingw,dist-x86_64-llvm-mingw,dist-x86_64-mingw,x86_64-mingw-1,x86_64-mingw-2 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 1, 2025
Stop adding MSYS2 to PATH try-job: dist-i686-mingw try-job: dist-x86_64-llvm-mingw try-job: dist-x86_64-mingw try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Member
|
r? me @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 2, 2025
Rollup of 8 pull requests Successful merges: - #145628 ([std][BTree] Fix behavior of `::append` to match documentation, `::insert`, and `::extend`) - #149241 (Fix armv4t- and armv5te- bare metal targets) - #149470 (compiletest: Prepare ignore/only conditions once in advance, without a macro) - #149507 (Mark windows-gnu* as lacking build with assertions) - #149508 (Prefer helper functions to identify MinGW targets) - #149516 (Stop adding MSYS2 to PATH) - #149525 (debuginfo/macro-stepping test: extend comments) - #149526 (Add myself (mati865) to the review rotation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 2, 2025
Rollup merge of #149516 - mati865:no-msys2, r=jieyouxu Stop adding MSYS2 to PATH Rust no longer requires MSYS2 provided tools like make.
mati865
added a commit
to mati865/rust
that referenced
this pull request
Dec 3, 2025
Revert rust-lang#149516 because it caused dist to pick up x86_64 `libwinpthreads.dll` dependency, resulting in broken toolchain.
mati865
added a commit
to mati865/rust
that referenced
this pull request
Dec 3, 2025
Revert rust-lang#149516 because it caused dist to pick up x86_64 `libwinpthreads.dll` dependency, resulting in broken toolchain. This reverts commit 5afd8ff, reversing changes made to 7cb02f9.
bors
added a commit
that referenced
this pull request
Dec 4, 2025
Revert #149516 to fix i686-pc-windows-gnu host Revert #149516 because it caused dist to pick up x86_64 `libwinpthreads.dll` dependency, resulting in broken toolchain. Note, I didn't use the procedure explained at: https://forge.rust-lang.org/compiler/reviews.html#reverts because the revert button isn't there. This reverts commit 5afd8ff, reversing changes made to 7cb02f9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust no longer requires MSYS2 provided tools like make.