Skip to content

Implement clamp_magnitude method for primitive floats & signed integers #148690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement clamp_magnitude method for primitive floats & signed integers #148690

wants to merge 1 commit into from
+289 −0

Conversation

@IntegralPilot
Copy link
Contributor

@IntegralPilot IntegralPilot commented Nov 8, 2025 •
edited
Loading

Tracking issue #148519
ACP rust-lang/libs-team#686

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Urgau
Urgau reviewed Nov 8, 2025
View reviewed changes
Urgau
Urgau reviewed Nov 8, 2025
View reviewed changes
@IntegralPilot IntegralPilot marked this pull request as ready for review November 8, 2025 12:37
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@IntegralPilot IntegralPilot mentioned this pull request Nov 8, 2025
Open
8 tasks
Zalathar
Zalathar reviewed Nov 9, 2025
View reviewed changes
@IntegralPilot
Copy link
Contributor Author

IntegralPilot commented Nov 9, 2025

@rustbot label -T-compiler

@rustbot rustbot removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 9, 2025
joboet
joboet reviewed Nov 13, 2025
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@IntegralPilot
Copy link
Contributor Author

IntegralPilot commented Nov 29, 2025 •
edited
Loading

Oh sorry, I'm currently without the ability to test a build locally for the moment so am using the CI to do so, I'll try and fix the issues the new commit introduced now.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@IntegralPilot IntegralPilot requested a review from joboet November 30, 2025 00:05
@joboet
Copy link
Member

joboet commented Nov 30, 2025

Oh sorry, I'm currently without the ability to test a build locally for the moment so am using the CI to do so, I'll try and fix the issues the new commit introduced now.

No worries!

joboet
joboet approved these changes Nov 30, 2025
View reviewed changes
Copy link
Member

@joboet joboet left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Please squash the commits into one, then I'll merge the PR.

View changes since this review

@IntegralPilot
Implement clamp_magnitude for floats & signed integers
ae7fa32 
Added feature gate, documentation and tests also.
@IntegralPilot
Copy link
Contributor Author

IntegralPilot commented Dec 1, 2025

Thanks so much for your review! I've squashed now.

@joboet
Copy link
Member

joboet commented Dec 1, 2025

👍
@bors r+

@bors
Copy link
Collaborator

bors commented Dec 1, 2025

📌 Commit ae7fa32 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau left review comments

@Zalathar Zalathar Zalathar left review comments

@joboet joboet joboet approved these changes

Assignees

@joboet joboet

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@IntegralPilot @rust-log-analyzer @rustbot @joboet @bors @Urgau @Zalathar