Skip to content

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Oct 17, 2025

Now that Miri has updated to the latest libffi-sys, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images.

If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes.

Closes #147556.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar
Copy link
Member Author

@bors try jobs=aarch64-gnu,aarch64-gnu-debug,aarch64-gnu-llvm-20-1,aarch64-gnu-llvm-20-2

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 17, 2025
ci: Switch back to default coreutils (uutils) after libffi-sys bump

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
try-job: aarch64-gnu-llvm-20-1
try-job: aarch64-gnu-llvm-20-2
@rust-bors
Copy link

rust-bors bot commented Oct 17, 2025

☀️ Try build successful (CI)
Build commit: 95ae112 (95ae112fedd15ff1568041486223bb6c5d15fb54, parent: 53a741fc4b8cf2d8e7b1b2336ed8edf889db84f4)

@jieyouxu
Copy link
Member

jieyouxu commented Nov 7, 2025

r? jieyouxu

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

jieyouxu commented Nov 7, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Nov 7, 2025

📌 Commit 439431a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@bors
Copy link
Collaborator

bors commented Nov 7, 2025

⌛ Testing commit 439431a with merge 843f8ce...

@bors
Copy link
Collaborator

bors commented Nov 7, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 843f8ce to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors bors merged commit 843f8ce into rust-lang:master Nov 7, 2025
13 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9606412 (parent) -> 843f8ce (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 843f8ce2ebc01d35a30484eadc8a84cdc6130844 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 5563.0s -> 7815.0s (+40.5%)
  2. dist-x86_64-apple: 6723.0s -> 8954.3s (+33.2%)
  3. pr-check-1: 1319.5s -> 1633.1s (+23.8%)
  4. pr-check-2: 2141.7s -> 2574.1s (+20.2%)
  5. x86_64-gnu-llvm-21-3: 5617.6s -> 6567.2s (+16.9%)
  6. x86_64-gnu-aux: 6012.5s -> 7011.2s (+16.6%)
  7. dist-various-1: 3879.1s -> 4492.5s (+15.8%)
  8. tidy: 173.3s -> 195.4s (+12.7%)
  9. dist-apple-various: 3644.7s -> 4027.0s (+10.5%)
  10. i686-gnu-1: 7041.6s -> 7678.0s (+9.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (843f8ce): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.5% [4.5%, 4.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.4% [-3.4%, -3.4%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.265s -> 483.325s (2.13%)
Artifact size: 390.81 MiB -> 390.81 MiB (-0.00%)

@Zalathar Zalathar deleted the uutils branch November 7, 2025 22:33
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
ci: Switch back to default coreutils (uutils) after libffi-sys bump

Now that Miri has updated to the latest `libffi-sys`, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images.

If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes.

- rust-lang#147581
- rust-lang/miri#4634
- rust-lang#147744

Closes rust-lang#147556.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libffi build error on aarch64-gnu-debug: unsupported option '-print-multi-os-directory'

6 participants