Skip to content

Don't create msi links for windows gnullvm targets #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2025
Merged

Don't create msi links for windows gnullvm targets #975

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b791d62
Don't create msi links for windows gnullvm targets
arnabanimesh Nov 5, 2025
9b6a1f1
Minor change
arnabanimesh Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions blacksmith/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ impl Blacksmith {
writeln!(buffer, "---------|--------|------|--------").unwrap();

for (name, platform) in &self.platforms {
let extensions: &[&str] = if name.contains("windows") {
let extensions: &[&str] = if name.contains("windows") && !name.contains("gnullvm") {
&["msi", "tar.xz"]
} else if name.contains("darwin") {
&["pkg", "tar.xz"]
Expand Down Expand Up @@ -312,7 +312,7 @@ impl Blacksmith {
writeln!(buffer, "---------|--------").unwrap();

for name in platforms {
let extensions: &[&str] = if name.contains("windows") {
let extensions: &[&str] = if name.contains("windows") && !name.contains("gnullvm") {
&["msi", "tar.gz"]
} else if name.contains("darwin") {
&["pkg", "tar.gz"]
Expand Down