Skip to content

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Oct 10, 2025

I find the message Building compile-time-deps always keep on the status bar, its animation effect disturbing for me:

image

I spent some time to debug the code, find out run_all_build_scripts panic here:

never!("Received compiler message for unknown package: {}", package);

the error message for panic is: Received compiler message for unknown package: registry+https://github.com/rust-lang/crates.io-index#[email protected]

I haven't found out why this panic happened. (if you want to reproduce it clone the rust compiler code, use the default vscode setting with x setup editor and choose rust-analyzer, then start the whole rust compiler project)

Anyway, this PR will handle the panic and send a report End, and it can resolve the issue.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2025
@chenyukang chenyukang changed the title Always send End even if run_all_build_scripts panic Always send report End even if run_all_build_scripts panic Oct 10, 2025
@chenyukang chenyukang force-pushed the yukang-fix-report-no-end branch from 63bab61 to 5226179 Compare October 10, 2025 13:09
@ChayimFriedman2
Copy link
Contributor

The never macro can panic, but only on debug builds or if you set the force-always-assert feature (I think the xtask task sets it though).

@ChayimFriedman2
Copy link
Contributor

I don't think we should catch_unwind() here. We should definitely check why the never! is failing though.

@chenyukang
Copy link
Member Author

ah, you are right, I haven't checked the never!, I will debug more on the failure if I have time.

@chenyukang chenyukang marked this pull request as draft October 10, 2025 13:39
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants