Always send report End even if run_all_build_scripts panic #20828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the message
Building compile-time-deps
always keep on the status bar, its animation effect disturbing for me:I spent some time to debug the code, find out
run_all_build_scripts
panic here:rust-analyzer/crates/project-model/src/build_dependencies.rs
Line 145 in b93180b
the error message for panic is:
Received compiler message for unknown package: registry+https://github.com/rust-lang/crates.io-index#[email protected]
I haven't found out why this panic happened. (if you want to reproduce it clone the rust compiler code, use the default vscode setting with
x setup editor
and chooserust-analyzer
, then start the whole rust compiler project)Anyway, this PR will handle the panic and send a report
End
, and it can resolve the issue.