Block high page numbers unconditionally #12181
Merged
+4
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove conditional blocking based on user-agent and IP address blocklists. Now all requests exceeding `max_allowed_page_offset` are blocked when the endpoint uses `.limit_page_numbers()`, regardless of the requesting client's identity. This simplifies the pagination logic and removes the need for maintaining blocklists while still protecting against performance issues from deep pagination.
Turbo87
added
C-internal 🔧
LawnGnome
approved these changes
Oct 25, 2025
eth3lbert
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove conditional blocking based on user-agent and IP address blocklists. Now all requests exceeding
max_allowed_page_offsetare blocked when the endpoint uses.limit_page_numbers(), regardless of the requesting client's identity.This simplifies the pagination logic and removes the need for maintaining blocklists while still protecting against performance issues from deep pagination.