Add mtopi CSR #360
Add mtopi CSR #360
Conversation
| #[cfg(test)] | ||
| #[macro_export] | ||
| macro_rules! test_ro_csr_field { | ||
| ($reg:ident, $field:ident: [$start:expr, $end:expr], $expected:expr) => {{ |
There was a problem hiding this comment.
You are not using start nor end. I the previous PR, this macro did a couple of extra checks (ensuring that the returned value matches the expected bit range)
There was a problem hiding this comment.
I'll definitely do this, I just need a bit of time... :)
Co-authored-by: Román Cárdenas Rodríguez <[email protected]>
|
I feel like this CI failing again, isn't the fault of the code changes made in this PR, the spellings were definitely not changed by me, I can & will fix this, but it's quiet late in my timezone... and as for the lints, same condition there, I'll fix them :) |
|
Don't worry about CI now, I will try to have it working ASAP (Nightly clippy triggers new errors from time to time). The checks that fail are not blockers for merging. Please, address the comment about the tests and it is good to go. |
2 participants
This PR reintroduces the mtopi CSR addition from my previous PRs (#347 and #359),
but from a clean branch as suggested by the reviewers.
The diff is identical to the intended changes; commit history has been cleaned up.