-
Notifications
You must be signed in to change notification settings - Fork 247
feat(env): underscore field nesting for single _
separators
#703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/// let source = Environment::default() | ||
/// .list_separator(",") | ||
/// .with_list_parse_key("my_list"); | ||
/// ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated but to clarify documentation which was a bit confusing for me
} | ||
|
||
#[test] | ||
fn test_parse_nested_double_separator() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without kebab case conversion, this is to ensure it works in simple mode as a mirror of the next test which enables single underscore nesting
f57ee26
to
69b6c74
Compare
Allow to nest with single `_` even when field names contain underscores via `.underscore_nesting(true)``. Can be used when field names also have `_` with environment overrides. Can be used as an alternative for double underscore separator '__' for nesting. Supports deep nesting. Is off by default.
69b6c74
to
5ca270f
Compare
Note that our contributing guide asks to start with Issues, rather than PRs. Moving this to a Draft until there is a mutual understanding and agreement on the problem and the solution. |
Ah, ok, thanks, will follow up. |
added #704 |
Allow to nest with single
_
even when field names contain underscores via.underscore_nesting(true)``. Can be used when field names also have
_` with environment overrides.Can be used as an alternative for double underscore separator '__' for nesting.
Supports deep nesting. Is off by default.