fix(get_key): for Xprv with key origin info
#872
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleonardolima
force-pushed
the
fix/getkey-xprv-bip32-with-orign
branch
2 times, most recently
from
df002e7 to
9869841
Compare
- fixes the implementation of `GetKey` for `Xprv` with `KeyRequest::Bip32` and a key_origin information. - adds a new test for a scenario where no wildcard is used, and an specific derivation index is used.
oleonardolima
force-pushed
the
fix/getkey-xprv-bip32-with-orign
branch
from
9869841 to
64483f3
Compare
oleonardolima
commented
Oct 31, 2025
| /// It is **not recommended** to use policy as a stable identifier for a miniscript. You should | ||
| /// use the policy compiler once, and then use the miniscript output as a stable identifier. See | ||
| /// the compiler document in [`doc/compiler.md`] for more details. | ||
| #[allow(rustdoc::broken_intra_doc_links)] |
There was a problem hiding this comment.
In the scenario that the intra docs link is being used (e.g [doc/compiler.md]), it has now become a warning.
Let me know if I should either keep this allow or just not use a intra-doc link anymore
tcharding
added a commit
to tcharding/rust-miniscript
that referenced
this pull request
Nov 3, 2025
We cannot link to a file by directory path in rustdocs. Just remove the link. This is breaking the docs build in rust-bitcoin#805 and is also mentioned in rust-bitcoin#872.
Merged
apoelstra
added a commit
that referenced
this pull request
Nov 3, 2025
f853906 Remove link to doc file (Tobin C. Harding) Pull request description: We cannot link to a file by directory path in rustdocs. Just remove the link. This is breaking the docs build in #805 and is also mentioned in #872. ACKs for top commit: apoelstra: ACK f853906; successfully ran local tests Tree-SHA512: d2e2eb182cb823297de53635ac23d55ff920b750d28efa7e18de08ddeda3a7f2bdffe8ff32dcf4c54ec32a33a176cea349291260388fd5e5cdad14c6c2e9802e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetKeyforXprvwithKeyRequest::Bip32and a key_origin information.