refactor: improve handling of project and logstream attributes in Gal…#483
Draft
AnkushMalaker wants to merge 1 commit intomainfrom
Draft
refactor: improve handling of project and logstream attributes in Gal…#483AnkushMalaker wants to merge 1 commit intomainfrom
AnkushMalaker wants to merge 1 commit intomainfrom
Conversation
…ileoOTLPExporter and GalileoSpanProcessor - Updated the exporter to conditionally set headers only if project and logstream attributes are present. - Enhanced the span processor to fallback to environment variables for project and logstream if not provided in context. - Adjusted tests to verify the new behavior, ensuring that None values are skipped and environment variables are utilized correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
- Coverage 82.63% 81.87% -0.77%
==========================================
Files 96 96
Lines 9157 9173 +16
==========================================
- Hits 7567 7510 -57
- Misses 1590 1663 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
…ileoOTLPExporter and GalileoSpanProcessor
Shortcut:
Description:
Tests:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Refines the handling of project and logstream attributes by introducing environment variable fallbacks and preventing null header overwrites. These changes ensure that
GalileoSpanProcessorandGalileoOTLPExportermaintain consistent metadata across different execution environments.GALILEO_PROJECTandGALILEO_LOG_STREAMinGalileoSpanProcessorand updateGalileoOTLPExporterto conditionally update headers only when attributes are present.Modified files (1)
Latest Contributors(2)
Modified files (1)
Latest Contributors(1)