Skip to content

Conversation

@bougyman
Copy link
Member

@bougyman bougyman commented Aug 2, 2025

  • refactor: Lowers AbcSize for building workers
  • chore: move instance methods to an instance method module and update impacted tests
  • feat: Adds Dry::Configurable extension, and makes #logger a configurable setting
  • feat: Adds graceful termination of workers

Copilot AI review requested due to automatic review settings August 2, 2025 16:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds graceful shutdown functionality to the NATS API server, allowing it to properly handle INT/TERM/QUIT signals and cleanly terminate workers. It also refactors the codebase by moving instance methods to a dedicated module and introducing Dry::Configurable for better configuration management.

  • Adds signal trapping for graceful shutdown of workers and thread pools
  • Refactors code by separating instance methods into an InstanceMethods module
  • Introduces Dry::Configurable extension and makes logger configurable

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

File Description
lib/leopard/nats_api_server.rb Implements graceful shutdown, adds instance methods module, and configurable logger
test/lib/nats_api_server.rb Updates test require path and adapts tests for instance method refactoring

@bougyman bougyman self-assigned this Aug 2, 2025
@bougyman bougyman added the enhancement New feature or request label Aug 2, 2025
@bougyman bougyman merged commit ce03fb0 into main Aug 3, 2025
4 checks passed
@bougyman bougyman deleted the graceful-shutdown branch August 3, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants