fix: Run in blocking mode, not just non-blocking #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the NATS API server was not properly spawning instances in blocking mode. The issue was that when the method returned early for non-blocking mode, it bypassed the instance spawning logic entirely.
- Stores the spawned instance pool in a variable before returning in non-blocking mode
- Ensures instances are always spawned regardless of blocking mode
stepdadbob
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning spawn instances (the pool) in non-blocking mode (for tests)
the behavior to spawn instances in blocking mode was removed. This adds
it back by storing the pool in a variable and returning it in non-blocking
mode.