JM: Pad unpadded back-nav eyebrows to match the standard eyebrow - #2296
Open
maebeale wants to merge 1 commit into
Open
JM: Pad unpadded back-nav eyebrows to match the standard eyebrow#2296maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
128 back-nav / eyebrow links used the eyebrow_link_class color but omitted the `px-2 py-1` the standard eyebrows carry, so they read slightly out of line. Add the padding so every back-nav eyebrow is visually identical (same helper, same class string). Left genuinely distinct muted links alone — text-xs "View all" links, edit/close toggle buttons, and eyebrows with special margins. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
marked this pull request as ready for review
August 21, 2026 13:33
Collaborator
Author
|
@jmilljr24 working on getting the site brandable by consolidating classes in general. had this as a tailwind apply and then converted to a helper. |
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 adds
px-2 py-1to 128 back-nav eyebrow links so they match the standard; verified by view specsFollow-up to #2292 (merged, added
eyebrow_link_class).Goal
eyebrow_link_classcolor but omitted thepx-2 py-1the standard eyebrows carry, so they sat slightly out of line.Scope
text-sm #{eyebrow_link_class}at the end of the class list) — confirmed nav links ("← Subscriptions", "Home", back links).text-xs"View all" links, edit/close toggle buttons (<summary>, search close-X, edit toggles), and a few eyebrows with special margins.Verification
Note