Skip to content

Fix typos and grammatical issues #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dduugg merged 2 commits into from
Mar 5, 2026
Merged

Fix typos and grammatical issues #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
253d81c
Fix typo: exludes -> excludes in test descriptions
dduugg Mar 5, 2026
5c7615a
Fix grammatical issues in documentation and tests
dduugg Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/visualize_packs/options_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ def self.parse(args)
opt.on('--no-node-todos', "Don't show package-based todos") { |o| options.show_node_todos = false }

opt.on('--focus-pack=STRING', "Focus on a specific pack(s). Comma-separated list of packs. Wildcards supported: 'packs/*'") { |o| options.focus_pack = o.to_s.split(",") }
opt.on('--focus-pack-edge-mode=STRING', "If focus-pack is set, this shows only between focussed packs (when set to none) or the edges into / out of / in and out of the focus packs to non-focus packs (which will be re-added to the graph). One of #{FocusPackEdgeDirection.values.map &:serialize}") { |o| options.show_only_edges_to_focus_pack = FocusPackEdgeDirection.deserialize(o) }
opt.on('--exclude-packs=', "Exclude listed packs from diagram. If used with include you will get all included that are not excluded. Wildcards support: 'packs/ignores/*'") { |o| options.exclude_packs = o.to_s.split(",") }
opt.on('--focus-pack-edge-mode=STRING', "If focus-pack is set, this shows only between focused packs (when set to none) or the edges into / out of / in and out of the focus packs to non-focus packs (which will be re-added to the graph). One of #{FocusPackEdgeDirection.values.map &:serialize}") { |o| options.show_only_edges_to_focus_pack = FocusPackEdgeDirection.deserialize(o) }
opt.on('--exclude-packs=', "Exclude listed packs from diagram. If used with include you will get all included that are not excluded. Wildcards supported: 'packs/ignores/*'") { |o| options.exclude_packs = o.to_s.split(",") }

opt.on('--roll-nested-into-parent-packs', "Don't show nested packs (not counting root). Connect edges to top-level pack instead") { |o| options.roll_nested_into_parent_packs = true }
opt.on('--no-nesting-arrows', "Don't draw relationships between parents and nested packs") { |o| options.show_nested_relationships = false }

opt.on('--remote-base-url=STRING', "Link pack packs to a URL (affects graphviz SVG generation)") { |o| options.remote_base_url = o }
opt.on('--remote-base-url=STRING', "Link packs to a URL (affects graphviz SVG generation)") { |o| options.remote_base_url = o }

opt.on('--title=STRING', "Set a custom diagram title") { |o| options.title = o }

Expand Down
8 changes: 4 additions & 4 deletions spec/visualize_packs_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,10 +429,10 @@
#Filtering + excluding (including wildcards)
['a1234c', true_, true_, 'dpav', 'a', ' ', ' ', nil, %w(packs/a/1), 'a 234c', 'exclude_packs removes node'],
['a1234c', true_, true_, 'dpav', 'a', ' ', ' ', nil, %w(packs/a/*), 'a 34c', 'exclude_packs with wildcard removes nodes'],
['a1234c', true_, true_, 'dpav', 'a', ' ', ' ', nil, %w(packs/a packs/a/*), ' 34c', 'exclude_packs with multiple exludes works'],
['a1234c', true_, true_, 'dpav', 'a', ' ', ' ', %w(packs/a), %w(packs/a), ' ', 'exclude_packs exludes focus'],
['a1234c', true_, true_, 'dpav', 'a', 'a1 ', ' ', %w(packs/a), %w(packs/a), ' 1 ', 'exclude_packs exludes focus but keeps dependency'],
['a1234c', true_, true_, 'dpav', 'a', ' ', ' ad1', %w(packs/a), %w(packs/a), ' 1 ', 'exclude_packs exludes focus but keeps todo'],
['a1234c', true_, true_, 'dpav', 'a', ' ', ' ', nil, %w(packs/a packs/a/*), ' 34c', 'exclude_packs with multiple excludes works'],
['a1234c', true_, true_, 'dpav', 'a', ' ', ' ', %w(packs/a), %w(packs/a), ' ', 'exclude_packs excludes focus'],
['a1234c', true_, true_, 'dpav', 'a', 'a1 ', ' ', %w(packs/a), %w(packs/a), ' 1 ', 'exclude_packs excludes focus but keeps dependency'],
['a1234c', true_, true_, 'dpav', 'a', ' ', ' ad1', %w(packs/a), %w(packs/a), ' 1 ', 'exclude_packs excludes focus but keeps todo'],
#Filtering + dependencies + todos + excluding
['a1234c', true_, true_, ' pa ', 'o', 'a1 2a', ' ad3 4aa apc', %w(packs/a), %w(packs/a), ' 1 c', 'combination of todo filtering, edge mode, focus, and exclude works'],
].each do |c|
Expand Down