Make rubocop-packs work as a RuboCop plugin#86
Conversation
3992078 to
5c60c12
Compare
5c60c12 to
a2eb19a
Compare
|
@jeromedalbert Would love to see this. Do your changes prevent it from working with older versions of rubocop, or is this backwards compatible? |
|
This is backwards compatible. People can use |
dduugg
left a comment
There was a problem hiding this comment.
Thanks for this! The migration from the old Inject monkey-patch to LintRoller::Plugin is a clean improvement and the implementation looks correct.
One minor nit: lib/rubocop/packs/plugin.rb uses # typed: false while the rest of the codebase uses typed: strict. Happy to take that as a follow-up if it's not straightforward to satisfy Sorbet here.
|
If I remember correctly I had issues with |
Resolves #85.
This PR adds support for RuboCop's Plugin feature: rubocop/rubocop#13792