-
Notifications
You must be signed in to change notification settings - Fork 18
Modernize dependencies and fix CI #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c4a0622
Update nokogiri to fix Ruby 3.4 compatibility
dduugg 1d2063e
Bump required_ruby_version to >= 3.2
dduugg d1ebeb8
Update all outdated gems
dduugg 3edc6a3
Regenerate tapioca RBI files for updated gems
dduugg b5f4e3a
Remove git packwerk override and bump packwerk dep to >= 3
dduugg 63834d1
Add rubocop-gusto plugin
dduugg fc6c1c4
Autocorrect rubocop offenses (rubocop -a)
dduugg db7feec
Generate .rubocop_todo.yml for remaining violations
dduugg ed64f7a
Regenerate rdoc RBI under Ruby 4.0
dduugg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # This configuration was generated by | ||
| # `rubocop --auto-gen-config` | ||
| # on 2026-03-05 18:26:56 UTC using RuboCop version 1.85.1. | ||
| # The point is for the user to remove these configuration records | ||
| # one by one as the offenses are removed from the code base. | ||
| # Note that changes in the inspected code, or installation of new | ||
| # versions of RuboCop, may require this file to be generated again. | ||
|
|
||
| # Offense count: 3 | ||
| Gusto/NoMetaprogramming: | ||
| Exclude: | ||
| - 'test/support/test_macro.rb' | ||
|
|
||
| # Offense count: 1 | ||
| Gusto/ToplevelConstants: | ||
| Exclude: | ||
| - 'test/test_helper.rb' | ||
|
|
||
| # Offense count: 1 | ||
| # Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods, WaywardPredicates. | ||
| # AllowedMethods: call | ||
| # WaywardPredicates: infinite?, nonzero? | ||
| Naming/PredicateMethod: | ||
| Exclude: | ||
| - 'lib/packwerk/privacy/checker.rb' | ||
|
|
||
| # Offense count: 3 | ||
| # This cop supports unsafe autocorrection (--autocorrect-all). | ||
| Performance/StringInclude: | ||
| Exclude: | ||
| - 'bin/rake' | ||
| - 'bin/rubocop' | ||
| - 'bin/tapioca' | ||
|
|
||
| # Offense count: 19 | ||
| # This cop supports safe autocorrection (--autocorrect). | ||
| # Configuration parameters: SuggestedStrictness. | ||
| Sorbet/FalseSigil: | ||
| Enabled: false | ||
|
|
||
| # Offense count: 45 | ||
| # This cop supports unsafe autocorrection (--autocorrect-all). | ||
| # Configuration parameters: SuggestedStrictness. | ||
| Sorbet/StrictSigil: | ||
| Enabled: false | ||
|
|
||
| # Offense count: 1 | ||
| # This cop supports unsafe autocorrection (--autocorrect-all). | ||
| Style/FileNull: | ||
| Exclude: | ||
| - 'test/rails_test_helper.rb' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,5 +3,3 @@ | |
| source 'https://rubygems.org' | ||
|
|
||
| gemspec | ||
|
|
||
| gem 'packwerk', git: 'https://github.com/Shopify/packwerk', branch: 'main' | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a fast-follow it could be worth letting claude take a pass through resolving/minimizing as many of these as we can.