feat: Add support for team: format and comprehensive tests#81
Merged
Conversation
- Update TEAM_REGEX to support team: format (without @ symbol) - Add comprehensive test suite for all team annotation formats - Test edge cases, invalid inputs, performance, and cross-platform compatibility - Ensure backward compatibility with existing @team and @team: formats - Add 7 new test functions covering 220+ lines of test code - All 68 tests pass, including new comprehensive test suite This addresses GitHub issue #131 and adds the requested team: format for better Ruby magic comment consistency.
technicalpickles
force-pushed
the
feat/team-annotation-formats
branch
from
878b3f4 to
07787d8
Compare
- Remove redundant test functions (test_comprehensive_team_formats, test_team_annotation_edge_cases, etc.) - Update existing test_team_regex to include new team: format tests - Reduce change from ~220 lines to ~22 lines while maintaining same functionality - All 61 tests pass with minimal, focused change
technicalpickles
force-pushed
the
feat/team-annotation-formats
branch
from
07787d8 to
2ac967f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the team: format (without @ symbol) and includes comprehensive tests for all team annotation formats. This addresses GitHub issue #131 and enhances the flexibility of team annotations.
Changes
Supported Formats
# @team MyTeam (current format)# @team: MyTeam (issue #131 format - already worked!)# team: MyTeam (Ruby-like format - newly added)Related Issues
Closes rubyatscale/code_ownership#131