Merged
Conversation
jackboberg
approved these changes
Mar 6, 2025
Contributor
jackboberg
left a comment
jackboberg
left a comment
There was a problem hiding this comment.
👍 Love the idea of trusting the generated file in environments where we can assume it is up to date and valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new
from-file --fastcommand that determines the file owner from the CODEOWNERS file.The main motivator is that this can be used from a ruby gem to find file owners in a deployed app when the CODEOWNERS file is always up to date.