Restore lockfile pinning and section handling lost in the Bundler parser switch - #9811
Merged
Merged
Conversation
The parser removed in #9564 turned a `!` entry in the DEPENDENCIES section into a `= <version>` requirement. Bundler's LockfileParser records the pinned source on the dependency and leaves the requirement at `>= 0`, so `gem install -g` could resolve a newer published version over the locked GIT or PATH one. Keeping the version as each section is read pins prereleases too, and lets a PATH section pin to the gemspec on disk the way the old parser did. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bundler::Source::Rubygems stores remotes in reverse of the lockfile order, so reading them straight through flipped which remote a spec downloads from when a GEM section lists more than one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
`defined?(previous_root)` is true even when the assignment never ran, so a failure before the root was saved reset Bundler's root to nil. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A PLUGIN SOURCE section sends Bundler::Plugin.from_lock looking for the plugin that handles it, and finding one loads and runs that plugin's `plugins.rb`. The plugin index is read from the lockfile directory, so a repository could run code just by being installed from with `gem install -g`. Nothing here can use a plugin source anyway. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hsbt
force-pushed
the
fix/request-set-lockfile-bang-pinning
branch
2 times, most recently
from
August 26, 2026 22:24
340eb2e to
1b9f1e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser removed in #9564 converted
a!entries in the DEPENDENCIES section into a= <locked version>requirement. Bundler'sLockfileParserrecords the pinned source on the dependency instead and leaves the requirement at>= 0, andGem::RequestSet#load_lockfileignores the source, sogem install -gcould resolve a newer published version instead of the locked GIT or PATH one.Restoring the assertions the old parser test carried surfaced three more regressions.
Bundler::Source::Rubygemsstores remotes in reverse of the lockfile order, flipping source priority for GEM sections with multiple remotes.Bundler::Plugin.from_lockraisesUnknownSourceErrorforPLUGIN SOURCEsections unless the plugin is installed, abortinggem install -gwhere the old parser skipped the section.defined?(previous_root)in theensureis true even when the assignment never ran, so an early failure could reset Bundler's root to nil.