csv-filter: add --output-quote-char#334
Merged
kou merged 7 commits intoruby:masterfrom Mar 22, 2025
BurdetteLamar:csv_filter_option_output_quote_char
Merged
csv-filter: add --output-quote-char#334kou merged 7 commits intoruby:masterfrom BurdetteLamar:csv_filter_option_output_quote_char
kou merged 7 commits intoruby:masterfrom
BurdetteLamar:csv_filter_option_output_quote_char
Conversation
BurdetteLamar
changed the title
kou
reviewed
Mar 11, 2025
test/csv/test_csv_filter.rb
Outdated
Comment on lines
95
to
99
| str = CSV.generate do |csv| | ||
| csv << ['foo', 0] | ||
| csv << ["'bar'", 1] | ||
| csv << ['"baz"', 2] | ||
| end |
Member
There was a problem hiding this comment.
Can we use literal CSV like others instead of CSV.generate?
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
kou
reviewed
Mar 11, 2025
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Member
|
Could you fix CI? (I hope that you check CI result by yourself.) |
Fix variable name.
kou
reviewed
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.