Made c4 also compile under Windows/Visual Studio.#33
Open
nubok wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added two lines in c4.c surrounding the
#include <unistd.h>with
to make c4 compile and run under Windows/Visual Studio, since
unistd.hdoes not exist under Windows/Visual Studio (it is a very UNIX-specific header). Note that despite looking otherwise the macro_WIN32is defined both when the conpilation target is 32 bit and 64 bit (cf. https://msdn.microsoft.com/en-us/library/b0084kay.aspx for reference) - thus adding this line does not add a future liability to consider when it should be planned to port c4 to 64 bit.I also added instructions to README.md in similar spirit to the existing guidelines how to do the same "experiments" in a suitable "Command Prompt for VS 2017".