Simplify symbol table: now a stack with locals on top hiding globals …#28
Open
tfisher98 wants to merge 3 commits into
Open
Simplify symbol table: now a stack with locals on top hiding globals …#28tfisher98 wants to merge 3 commits into
tfisher98 wants to merge 3 commits into
Conversation
Owner
|
This doesn't work if a function declares a local with the same name as a global. The Hxx fields were designed to save and restore the global Class/Type/Val in that case. Although with a bit of work, you may be able to handle that case with your new approach. |
Author
|
You were right; it didn't work. I think I fixed it, but the case for it being a simplification is not so strong anymore. More it is just a slightly different approach. It has the upside that it generalizes more easily to allowing additional nested local scopes. And it is still at -1 net lines of code :^) |
Owner
|
This is very interesting and clever! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…below.