Improve performance by only load textures up to once per tick#148
Open
greenpixels wants to merge 10 commits intorsubtil:masterfrom
Open
Improve performance by only load textures up to once per tick#148greenpixels wants to merge 10 commits intorsubtil:masterfrom
greenpixels wants to merge 10 commits intorsubtil:masterfrom
Conversation
…instead of using the event.device
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Sorry for the delay, I am in the midst of other projects.
Please see #140 for more information. More specifically my #140 (comment) about this.
This PR introduces a internal
_should_trigger_texture_loadvariable.Now, instead of calling
_load_texture_path, we now set_should_trigger_texturetotrue.If it is
true, we load every texture that has requested it in that frame.This reduced the calls to _load_texture_path by 68% in my godot game project that uses this library.