fix(fill): remove ui/text outputs from document flow #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434
When
uiOutput()ortextOutut()are used in a fillable container but are empty, users expect that those elements are entirely invisible or completely removed. In adisplay: flexcontext, however, empty divs are still included in the allocation of space.Example app
Before
Notice the empty space between the two cards is almost three times larger than expected when the UI and text outputs are empty. Note that when the example app uses
uiOutput("card_b", fill = TRUE), the problem is even worse.After