Rework spec checking for active job leaks to handle new ActiveJob::TestHelper implementation - #2919
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 8.2 changed the active job test helper in such a way that in certain load orders, the adapter for
ActiveJob::Baseis cached, this implementation then overrides the configuration which results in our setup during a regression test for checking that queues don't leak between jobs breaking because the job and test have different queues, and the test never sees the job at all let alone leak.You can verify this locally by using a seed such as
40770, or running the spec in isolation and changing the assertion for the adapter to: