Skip to content

Fix for the PC-Engine, TurboGrafx 16, SuperGrafx emulator.#4

Open
SoftechSoftware wants to merge 11 commits intorsn8887:masterfrom
SoftechSoftware:master
Open

Fix for the PC-Engine, TurboGrafx 16, SuperGrafx emulator.#4
SoftechSoftware wants to merge 11 commits intorsn8887:masterfrom
SoftechSoftware:master

Conversation

@SoftechSoftware
Copy link

No description provided.

@rsn8887
Copy link
Owner

rsn8887 commented Jan 11, 2018

Great!

However, I have to manually apply your commits because you are not following the coding format of the existing source files. Also, I cannot merge a PR unless it is based on the latest HEAD.

To make all this easier, could you please base your PR's on the latest HEAD (either mine or CPasjuste's, at the moment, I am a few commits ahead of him). Then also

  • use curly braces in the same way as the rest of the file you are editing
  • depending on the file, please use spaces or tabs in the same way as in the rest of the file.
  • please use comments as in the rest of the file. You see there are no comments like ///cpasjuste or ///rsn8887 showing the author of every line, so please don't insert your own. Git history already keeps track of that and it makes the code too hard to read.

I am not the maintainer of this project, I just want to make it as easy as possible for Cpasjuste to accept these changes into the upstream repo eventually.

Thanks!

@SoftechSoftware
Copy link
Author

SoftechSoftware commented Jan 12, 2018

Hi!
I'm coding in C++ since 25 years, so now I have my coding style finding difficulty to remember each time to use a different coding style while fixing PFBA. So feel free to modify my coding style to meet PFBA style requirements!
It's not my intention to become an official PFBA manteiner, simply I gifted to my brother a PS Vita for his birthday and found that the excellent PFBA had some bugs and some emulators not working, then I decided to dig into the code to see if it was possible to fix some of them.
Again, I'm of the very old school C++ programmers so I'm not very used with GIT, I use SourceTree as a frontend for it, I don't use GIT from Bash and/or DOS prompt. This means that I have little difficult understanding what do you mean with "base your PR's on the latest HEAD", for example.
Again, I only forked Cpasjuste's PFBA into my repository. I do pull requests to you and to Cpasjuste straight from the GitHub website...
If it can help, in the future I could just send you the modified files. Just let me know an email address...

@SoftechSoftware
Copy link
Author

BTW, using curly braces in the PFBA way makes the code hard to read and the execution flow difficult to follow , IMHO....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants