Repository navigation
feat(skills): bundle the llm-skills skill with validation, project-check and scan scripts - #90
Merged
Merged
Conversation
…eck and scan scripts test(skills): cover the bundled skill scripts end to end docs: move the agent guide to AGENTS.md Consumers get a user-invoked manual for everything around skills (setup, publishing, trust, audit, discovery, authoring) plus deterministic PHP checks, since the README does not ship in the dist archive. The package now declares `extra.skills.source`, so the skill arrives through the usual built-in `llm/*` trust. Assisted-By: Claude Opus 5.5
The plugin only needs to trust itself; a vendor-wide pattern would also trust any future package published under `llm/`. Assisted-By: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
llm/skillsnow ships its own skill,llm-skills(resources/skills/llm-skills/, declared viaextra.skills.source). Consumers receive it like any other donor skill; it is user-invoked only (disable-model-invocation: true).llm/*is narrowed tollm/skills: the plugin only needs to trust itself, not every future package under thellmvendor.SKILL.mdis a table of contents; references cover setup andskills.local.json, commands beyond--help, remote/dirsources and the skill lifecycle, publishing and internal skills, trust and how to widen or lock it, auditing third-party skills (manual checklist, Cisco skill-scanner, NVIDIA SkillSpector, Snyk agent-scan), finding skills, writing skills (with a pointer tomattpocock/skills→writing-for-agents), and troubleshooting.validate-skill.php(Agent Skills spec + the plugin's own name/frontmatter rules),check-project.php(config validity, git hygiene of target/aliases/skills.local.json, a package's shipped skills),scan-skill.php(deterministic security pre-screen: invisible Unicode, pipe-to-shell, secret reads, injection phrasing, binaries).CLAUDE.md→AGENTS.md, with a rule that the bundled skill is updated together with any behaviour change.Why?
Consumers only get
src/,resources/andbin/in the dist archive, so the README never reaches them or their agents. The skill gives an agent in a consumer project an accurate manual of the installed version plus checks it can run.Review notes
*is rejected as a pattern (README and the untrusted-skip hint suggest--trust=*andextra.skills.trusted), the schema says--no-scriptssuppresses auto-sync (it does not), the discovery-off hint namesextra.skills.discovery, a localtrusted-replace: false/vendor-sources: truere-opens trust, and declared source subfolders withoutSKILL.mdare still installed. Worth fixing in the plugin separately;troubleshooting.mdthen needs the matching edit.llm-skillsfrom the path-installed plugin, so three trust tests list it in their expected sets.Checklist