Make setting entity values optional #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
As described in the issue, add a boolean flag that allows users to choose whether to set each entity property or ignore it.
Note that booleans being booleans there are two ways we can do this, each with tradeoffs.
I went for a
set_[property]approach since I feel it's generally clearer thanignore_[property](you don't need to negate in your head!) but really the main consideration should be with message default initialization of the boolean tofalse, whether we want to "set by default" (ignore_[property]flag) or "ignore by default" (set_[property]flag).