Skip to content

Conversation

@jrhoads
Copy link
Member

@jrhoads jrhoads commented Jan 26, 2026

Purpose

The purpose of this PR is to deprecate and remove support for ROR Schema version 1 (v1) from the manual indexing and index dump CI/CD workflows. This ensures the workflows primarily target the current v2 schema.

Approach

The changes involve updating GitHub Action workflow files to remove logic branches and input options related to v1.

Key Modifications

  • dev_index_dump.yml:
    • Removed v1 from the schema version choice list.
    • Simplified the script execution to strictly use the INDEX_DUMP_DEV_API_URL_V2 secret, removing the conditional check for schema versions.
  • dev_manual_index.yml:
    • Removed v1 from the schema version choice list.
    • Removed the validation step logic specific to v1 (which used the master ror_schema.json).
    • Removed the indexing step logic specific to v1 (which used the INDEX_DEV_API_URL_V1 secret).

Important Technical Details

  • The workflows now default to using the V2 API endpoints and secrets.
  • Validation for schema versioning in dev_manual_index.yml now focuses exclusively on the v2_1 schema specification.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant