Repository navigation
Conversation
Test Results 22 files 22 suites 3d 13h 40m 3s ⏱️ For more details on these failures, see this check. Results for commit e861e8f. ♻️ This comment has been updated with latest results. |
jblomer
force-pushed
the
ntuple-huge-file-write
branch
from
November 8, 2026 22:07
15ab5b7 to
fc9b1ea
Compare
Prepares for applying automatic cluster group creation in the argumentless overload while following the explicit cluster group steering parameter in the other overload.
Move the check for an empty cluster group from the callers of RPageSink::CommitClusterGroup() to that method itself. Return immedately without doing anything if there is no new cluster to commit.
jblomer
force-pushed
the
ntuple-huge-file-write
branch
from
November 8, 2026 22:23
fc9b1ea to
e861e8f
Compare
If a cluster commit surpasses the cluster group page threshold, automatically commit a cluster group.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically cut cluster groups based on number of pages written. Drop page metadata once page list is written.