Skip to content

[core] Add essential unit tests for TObjArray - #23680

Merged
pcanal merged 3 commits into
root-project:masterfrom
ravindra-RKB:feature-tobjarray-tests
Oct 26, 2026
Merged

pcanal merged 3 commits into
root-project:masterfrom
ravindra-RKB:feature-tobjarray-tests

Conversation

@ravindra-RKB

Copy link
Copy Markdown
Contributor

This PR introduces essential unit tests for the TObjArray collection class to the core/cont module. It verifies common operations like appending, inserting, removing, and iterating over objects within the array, ensuring long-term stability and correctness for this fundamental container against the ROOT test framework.

Checklist

  • tested changes locally
  • updated the docs (if necessary)

Comment thread core/cont/test/TObjArrayTest.cxx Resolved
Comment thread core/cont/test/TObjArrayTest.cxx Resolved

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good start. Thanks.

@ravindra-RKB

Copy link
Copy Markdown
Contributor Author

Thanks for the review @pcanal! I've updated the tests with:

  • Checks for removing middle and last elements with RemoveAt, along with Compress().
  • A TrackObject class to verify allocation/deallocation behavior between Clear() and Delete().

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 20h 5m 22s ⏱️
 3 896 tests  3 896 ✅ 0 💤 0 ❌
79 601 runs  79 601 ✅ 0 💤 0 ❌

Results for commit 716eebc.

♻️ This comment has been updated with latest results.

@ravindra-RKB

Copy link
Copy Markdown
Contributor Author

Hi @pcanal, just a gentle ping on this. The requested test enhancements have been added and all TObjArray unit tests are passing cleanly across platforms. Whenever you have a moment, please let me know if anything else is needed or if this is ready to merge.

@pcanal pcanal closed this Oct 15, 2026
@pcanal pcanal reopened this Oct 15, 2026
@pcanal

pcanal commented Oct 15, 2026

Copy link
Copy Markdown
Member

Closing and Reopening to rebase the CI tests

@ravindra-RKB

Copy link
Copy Markdown
Contributor Author

Hi @pcanal - just a gentle ping on this. The PR is approved and all TObjArray unit tests passed cleanly in CI. Could this be merged when you have a moment? Thank you!

@pcanal pcanal closed this Oct 21, 2026
@pcanal pcanal reopened this Oct 21, 2026
@pcanal
pcanal force-pushed the feature-tobjarray-tests branch from 4cfbdaa to 5aa9bb6 Compare October 21, 2026 21:12
@ravindra-RKB

Copy link
Copy Markdown
Contributor Author

Hi @pcanal - I noticed the CI run after the recent update. Please let me know if there is anything needed from my end on TObjArray. Thank you!

@pcanal pcanal closed this Oct 22, 2026
@pcanal pcanal reopened this Oct 22, 2026
@pcanal pcanal closed this Oct 22, 2026
@pcanal pcanal reopened this Oct 22, 2026
@pcanal
pcanal force-pushed the feature-tobjarray-tests branch from 5aa9bb6 to 716eebc Compare October 22, 2026 17:27
@ravindra-RKB

Copy link
Copy Markdown
Contributor Author

Hi @pcanal - just following up on this. The PR is approved and all 3,896 tests passed (the ubuntu2610 failure appears to be a runner issue). Could this be merged when convenient? Thank you!

@pcanal
pcanal merged commit 84dce02 into root-project:master Oct 26, 2026
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants